Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix god command for console #263

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Fix god command for console #263

merged 2 commits into from
Jan 12, 2018

Conversation

godwhoa
Copy link
Member

@godwhoa godwhoa commented Jan 12, 2018

Changes:

  • Fix traceback.print_exc usage
  • Refactor god command's validation

Closes: #262

@NotAFile
Copy link
Member

hm, this does make the error message more unfriendly if you just misspelled a name

@godwhoa
Copy link
Member Author

godwhoa commented Jan 12, 2018

It outputs this if they get the name wrong

2018-01-12 23:04:31+0530 [-] Invalid Player
2018-01-12 23:04:31+0530 [-] Usage: /god [player]

@godwhoa
Make it work without arguments
44443c3 
Note: doesn't apply to console
@NotAFile
Copy link
Member

Okay, nevermind then

@feikname feikname added PR: solve-bug This PR aims to solve a bug core commands This issues involves piqueserver's core commands labels Jan 12, 2018
@godwhoa godwhoa merged commit 8db974b into master Jan 12, 2018
@feikname feikname deleted the fix-god branch January 12, 2018 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAFile NotAFile NotAFile approved these changes

Assignees
No one assigned
Labels
core commands This issues involves piqueserver's core commands PR: solve-bug This PR aims to solve a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@godwhoa @NotAFile @feikname