Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to cython language level 3 #389

Merged
merged 13 commits into from Nov 6, 2018
Merged

Port to cython language level 3 #389

merged 13 commits into from Nov 6, 2018

Conversation

godwhoa
Copy link
Member

@godwhoa godwhoa commented Oct 26, 2018 •
edited

Closes: #374
Closes: #291

@godwhoa godwhoa requested a review from NotAFile October 26, 2018 21:44
NotAFile
NotAFile reviewed Oct 26, 2018
View reviewed changes
setup.py Outdated Show resolved Hide resolved
NotAFile
NotAFile requested changes Oct 26, 2018
View reviewed changes
Copy link
Member

@NotAFile NotAFile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you set it to language level 3. Yeah, that won't work. There's still code that needs to be changed for that. The idea was to set it to 2 for now to stop the build from breaking in the next cython update.

@godwhoa
Copy link
Member Author

godwhoa commented Oct 26, 2018

There's still code that needs to be changed for that.

I don't mind working on that

@godwhoa godwhoa changed the title Set language_level and embedsignature compiler directives for Cython Port to cython language level 3 Oct 26, 2018
@godwhoa
Copy link
Member Author

godwhoa commented Oct 26, 2018

@NotAFile could you help me figure out what more is left to do?
So far got the build passing and verified mapmaker works by using "classicgen" and "random" maps.

@feikname feikname added PR: refactoring This PR includes code refactoring WIP This PR is still being worked on and is not to be merged labels Oct 28, 2018
@godwhoa
Fix naming for ByteWriter
c5ec667 
ByteWriter reader -> ByteWriter writer
reader.write* -> writer.write
@godwhoa
Use libc.math
8280fde
@godwhoa
Expand star imports
f152e0f
@godwhoa
Fix write_* functions
667e892 
These were broken with reader -> writer rename
@godwhoa
Clean up more imports
322dc23 
* fixed import error for fabs
* removed unused imports
* expanded star imports
@feikname feikname removed the WIP This PR is still being worked on and is not to be merged label Nov 5, 2018
@feikname feikname added this to the 1.0.0 milestone Nov 5, 2018
@godwhoa godwhoa merged commit a23cf19 into master Nov 6, 2018
@godwhoa godwhoa deleted the langlevel branch November 6, 2018 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAFile NotAFile NotAFile approved these changes

Assignees
No one assigned
Labels
PR: refactoring This PR includes code refactoring
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@godwhoa @NotAFile @feikname