Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add develop and clean make targets #391

Merged
merged 2 commits into from Oct 27, 2018
Merged

add develop and clean make targets #391

merged 2 commits into from Oct 27, 2018

Conversation

samuelallan72
Copy link

  • clean to remove everything from a make develop
  • develop to install inplace (same as python setup.py develop

- `clean` to remove everything from a `make develop`
- `develop` to install inplace (same as python setup.py develop
@samuelallan72
Copy link
Author

There seems to be multiple ways of installing/running various things now: the Makefile, python setup.py <command>, pip <command>... We have more make targets now, but they aren't documented in the readme development instructions. Not sure what to do about it.

@samuelallan72
Copy link
Author

Also should be noted that the make commands all assume a virtualenv has already been loaded. I think this is good because we don't want to assume the location/python version of a venv, but this isn't documented yet either.

Copy link
Member

@godwhoa godwhoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll do

@NotAFile NotAFile merged commit 21c3e79 into master Oct 27, 2018
@feikname feikname added the PR: improvement This PR includes an enhancement to piqueserver label Oct 28, 2018
@feikname feikname added this to the 1.0.0 milestone Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: improvement This PR includes an enhancement to piqueserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants