Add better farbuild exploit mitigation #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mitigation used to be very flakey and had many false positives. Inspired by 1AmYF's new fbpatch2 mitigation script, which is much less better than the original fbpatch mitigation, we now record and check the start location of the line build in addition to the end location.
NotAFile
requested review from
samuelallan72,
feikname and
godwhoa
and removed request for
samuelallan72
|
Tested it? |
|
I haven't tested if the farbuild exploit works with this this exact patch, but line building works and the check is identical to the existing one above. I did want to try adding some unit tests though. |
feikname
added
PR: improvement
godwhoa
approved these changes
Mar 16, 2019
|
ftr, @godwhoa tested this and it worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigation used to be very flakey and had many false positives.
Inspired by 1AmYF's new fbpatch2 mitigation script, which is much
better than the original fbpatch mitigation, we now record and check the
start location of the line build in addition to the end location.
This is now also more readable because these checks are actually in the correct place now, right with the other packet validity checks.