document and fix everyone_is_admin functionality #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotAFile
approved these changes
May 28, 2019
NotAFile
requested changes
May 28, 2019
piqueserver/config/config.toml
Outdated
| @@ -196,6 +196,10 @@ color = [ 0, 255, 0] | |||
| #guard = ["guardpass"] | |||
| #trusted = ["trustedpass"] | |||
|
|
|||
| # Include an empty password for the admin role to automatically log in everyone | |||
| # as admin. Could be useful for testing. | |||
| #admin = [""] | |||
There was a problem hiding this comment.
I don't like this, as it's implicit and could happen accidentally, which is why we removed this behavior initially. I'd prefer a designated everyone_is_admin option. I thought we already had that, but seems not.
There was a problem hiding this comment.
i'm not sure we ever did remove the behaviour. it was still there, just one /reloadconfig away...
NotAFile
approved these changes
May 29, 2019
samuelallan72
force-pushed
the
swall/fix-everyoneisadmin
branch
from
618f3a0
to
95ad30f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would only be activated upon
/reloadconfig. Now it's moved into the core so it will be activated from the start.fixes #295