support for creating backups to S3 via snapshot mechanism #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
backups
branch
2 times, most recently
from
d92df25
to
6b3b76b
Compare
WanzenBug
force-pushed
the
backups
branch
4 times, most recently
from
4067bfe
to
80a0fad
Compare
WanzenBug
force-pushed
the
backups
branch
3 times, most recently
from
fbadc42
to
7dc8761
Compare
WanzenBug
changed the title
|
I won't be able to review this immediately, but I will get to it. |
WanzenBug
force-pushed
the
backups
branch
3 times, most recently
from
bd9a102
to
638b1de
Compare
In addition to the normal "in-cluster" snapshots, the user can also select backups to S3 by providing parameters when creating the snapshot. The parameters can be used to set up a LINSTOR "remote" object, which represents a S3 endpoint. Any snapshot using those parameters will be created using LINSTORs backup feature. Restoring from a snapshot that only exists on a remote location does works, as long as the "remote" is configured beforehand. The CSI spec does not pass any parameters when registring an existing snapshot. This feature requires LINSTOR 1.18.0 to work. Previous versions did not allow for customizing the snapshot name. This made it impossible to create an implementation that adheres to the CSI spec, as there was no way to map the requested snapshot name to any form of stable snapshot ID. Signed-off-by: Moritz "WanzenBug" Wanzenböck <moritz.wanzenboeck@linbit.com>
JoelColledge
approved these changes
Feb 23, 2022
|
@WanzenBug am I right that this code uses old "snapshot shipping" mechanism which is considered deprecated?
|
|
It seems it uses new backups API |
|
Yeah, it only uses the new backups API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the normal "in-cluster" snapshots, the user can also select
backups to S3 by providing parameters when creating the snapshot.
The parameters can be used to set up a LINSTOR "remote" object, which
represents a S3 endpoint. Any snapshot using those parameters will be
created using LINSTORs backup feature.
Restoring from a snapshot that only exists on a remote location does works,
as long as the "remote" is configured beforehand. The CSI spec does not
pass any parameters when registring an existing snapshot.
This feature requires LINSTOR 1.18.0 to work. Previous versions did not
allow for customizing the snapshot name. This made it impossible to create
an implementation that adheres to the CSI spec, as there was no way to
map the requested snapshot name to any form of stable snapshot ID.