Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation #23

Merged
merged 10 commits into from
Jun 4, 2020
Merged

Add documentation #23

merged 10 commits into from
Jun 4, 2020

Conversation

nelsongallardo
Copy link
Contributor

Purpose 💪

Adding documentation

cesaraugustogarcia
cesaraugustogarcia previously approved these changes May 31, 2020
View reviewed changes
Copy link
Contributor

@cesaraugustogarcia cesaraugustogarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
One minor suggestion is that we could add example calls, but we can do it later.
🚀

cesaraugustogarcia
cesaraugustogarcia approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@cesaraugustogarcia cesaraugustogarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grat job! Please do not forget to squash

@nelsongallardo nelsongallardo merged commit f49a3ec into master Jun 4, 2020
@nelsongallardo nelsongallardo deleted the add-documentation branch June 4, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesaraugustogarcia cesaraugustogarcia cesaraugustogarcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nelsongallardo @cesaraugustogarcia