-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Game meta, data validation and schema #358
Conversation
Freeing up the key status to represent the total status of game
huh, I didn't realise people were using |
I'm about to push a change for that
I think we should put this kind of misc information into the |
Good idea; it's something to watch out for though, because it means playability isn't a simple true/false value, there needs to be a 'partial' option. Depending on who you ask, a game isn't playable unless all of it is playable, or it's playable as long as a small portion of it is. |
New schema: status: complete | playable | unplayable
development: complete | very active | active | sporadic | halted
Just added 'complete' value to If we try to add
Or if you try to add
This gets us a bit closer to #30 (comment) |
* Development tag background colour changed
|
Cool, changed status schema to status: playable | semi-playable | unplayable |
I think if we change the playable: yes | partial | no Or something along those lines... |
b9e4c5d
to
dac8154
Compare
Genre/theme info from www.giantbomb.com/games |
Using 'youtube' media instead of 'raw'. Raw embed code goes out of date, using YouTube video ID instead. It also allows more uniformity in how videos are displayed.
Most of the raw embeds were not working, the embed code changes too often it seems.
While thumbnails are still used don't force all images to be the same size, just fit the ones exceeded 500px width.
Most of the youtube embed code was broken, fixed by:
Now all of the 30+ youtube videos are working again ✨ |
- Seperated genre/subgenre schema and validation values - Cleaned up games meta data for more compact display
It will remove images/embeds when closed now, which stops any videos playing and is easier on memory usage.
Thanks for this, lets run with it. |
Also the template needs to be changed to new people submit issues & pull requests https://github.com/piranha/osgameclones/blob/master/.github/ISSUE_TEMPLATE.md |
Wow, that's pretty cool what you did here! |
Using
pykwalify
library to make sure the structure of games.yaml is valid. It picked up a lot of errors even in this basic form - see schema.yaml. More validating can be added later throughpykwalify
extensions.Some of the erors picked up in
game
structure :With
status
constrained to[complete, active, sporadic, halted]
:Related: #30
Closes: #336 #353 #360