Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging tab-close button results in its selection, tab close #22

Closed
ferongr opened this issue Dec 4, 2011 · 4 comments
Closed

Dragging tab-close button results in its selection, tab close #22

ferongr opened this issue Dec 4, 2011 · 4 comments

Comments

@ferongr
Copy link

ferongr commented Dec 4, 2011

Similar like issue #20.

Reproduce steps:

  1. Click (LMB down) on tab-close button
  2. Drag mouse outside outside the button
  3. Release mouse button

Expected result: Nothing happens (tab doesn't close)

Actual result: Tab-close button gains blue overlay, tab closes.

Re-used screenshot from issue #20 since the same exact thing happens.
@ryancu7
Copy link

ryancu7 commented Mar 4, 2015

I came here to report this bug and see it has already been reported. Hopefully it can be fixed soon. I get trapped by this all the time.

@piroor
Copy link
Owner

piroor commented Mar 4, 2015

This is not a bug but a designed behavior. MTH provides ability to close multiple tabs at once by dragging on clsoeboxes of tabs.
However, as you said this feature is possibly annoying. So I think that selection of closeboxes should be started after the second closebox is selected.

@ryancu7
Copy link

ryancu7 commented Mar 4, 2015

Ah, I see. Thanks for the reply. I think your idea will work well.

piroor added a commit that referenced this issue Mar 4, 2015
@piroor
Don't make the first tab ready-to-close until secondary tab is marked…
3fd497a 
… as ready-to-close.

On generic GUI, clicking operation can be canceled by drag-mouseout-and-release. Clicking on a closebox of the first tab should be cancelable with the operation, instead of starting to select the tab.
See also #22
@piroor
Copy link
Owner

piroor commented Mar 4, 2015

The commit 3fd497a introduces this behavior. You can try it with the latest development build: http://piro.sakura.ne.jp/xul/xpi/nightly/

@piroor piroor closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piroor @ferongr @ryancu7