Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/seqan3 #174

Merged
merged 29 commits into from
Jul 22, 2021
Merged

Feature/seqan3 #174

merged 29 commits into from
Jul 22, 2021

Conversation

pirovc
Copy link
Owner

@pirovc pirovc commented Jul 8, 2021

  • full integration of seqan3
  • offset is now implemented in the ganon side, no support from seqan3
  • results are quite similar, small differences due to new hash and fixed offset calculation on paired reads
  • adjusted test results
  • drop in core performance up to 15%

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #174 (2c218b0) into dev (83e38c5) will increase coverage by 0.20%.
The diff coverage is 85.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #174      +/-   ##
==========================================
+ Coverage   77.66%   77.87%   +0.20%     
==========================================
  Files          22       22              
  Lines        2525     2517       -8     
==========================================
- Hits         1961     1960       -1     
+ Misses        564      557       -7     
Impacted Files Coverage Δ
src/ganon-build/include/ganon-build/Config.hpp 43.54% <33.33%> (-1.91%) ⬇️
...c/ganon-classify/include/ganon-classify/Config.hpp 50.32% <55.55%> (+0.32%) ⬆️
src/ganon/classify.py 88.23% <66.66%> (-5.89%) ⬇️
src/ganon-build/CommandLineParser.cpp 87.87% <87.50%> (ø)
src/ganon-classify/GanonClassify.cpp 83.59% <90.00%> (+0.77%) ⬆️
src/ganon-build/GanonBuild.cpp 69.23% <90.90%> (+1.71%) ⬆️
src/ganon-classify/CommandLineParser.cpp 83.95% <100.00%> (+1.89%) ⬆️
src/ganon/build_update.py 65.66% <100.00%> (+0.18%) ⬆️
src/ganon/config.py 77.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e38c5...2c218b0. Read the comment docs.

@pirovc pirovc merged commit 62a976f into dev Jul 22, 2021
@pirovc pirovc deleted the feature/seqan3 branch October 26, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants