-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/seqan3 #174
Merged
Merged
Feature/seqan3 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pirovc
commented
Jul 8, 2021
•
edited
Loading
edited
- full integration of seqan3
- offset is now implemented in the ganon side, no support from seqan3
- results are quite similar, small differences due to new hash and fixed offset calculation on paired reads
- adjusted test results
- drop in core performance up to 15%
Codecov Report
@@ Coverage Diff @@
## dev #174 +/- ##
==========================================
+ Coverage 77.66% 77.87% +0.20%
==========================================
Files 22 22
Lines 2525 2517 -8
==========================================
- Hits 1961 1960 -1
+ Misses 564 557 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.