Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard tools #358

Merged
merged 10 commits into from
Apr 16, 2020
Merged

Shard tools #358

merged 10 commits into from
Apr 16, 2020

Conversation

elshize
Copy link
Member

@elshize elshize commented Apr 6, 2020

This introduces a shards tool that can be used to run several tools for shards without a bug-prone bash script.

Before merging, I want to update the docs, so that's missing, but I want to get the feedback first.

@elshize elshize added the enhancement New feature or request label Apr 6, 2020
@elshize elshize added this to the v1.0 milestone Apr 6, 2020
@elshize elshize self-assigned this Apr 6, 2020
Copy link
Member

@JMMackenzie JMMackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan. Looks good to me, nice work.

@JMMackenzie JMMackenzie self-requested a review April 7, 2020 00:08
Copy link
Member

@JMMackenzie JMMackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about Travis build

include/pisa/sharding.hpp Outdated Show resolved Hide resolved
@elshize elshize changed the title Shards tools Shard tools Apr 7, 2020
@amallia amallia merged commit a59a8e9 into master Apr 16, 2020
@amallia amallia deleted the shards-tools branch April 16, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants