Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of top-k threshold task #426

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Fix bug of top-k threshold task #426

merged 1 commit into from
Aug 20, 2020

Conversation

amallia
Copy link
Member

@amallia amallia commented Aug 16, 2020

Fixes #425.

Changes proposed in this pull request:

  • clear top-k heap after every query execution

@amallia amallia requested a review from elshize August 16, 2020 13:40
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #426 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   92.51%   92.49%   -0.03%     
==========================================
  Files          91       91              
  Lines        4932     4932              
==========================================
- Hits         4563     4562       -1     
- Misses        369      370       +1     
Impacted Files Coverage Δ
include/pisa/bit_vector.hpp 97.54% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2ae8b...a2558ba. Read the comment docs.

@elshize elshize merged commit 63b17b6 into master Aug 20, 2020
@elshize elshize deleted the threshold-bugfix branch August 20, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate threshold estimation
2 participants