Make NoSuchFile inherit from std::exception #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that it can be caught with a generic `catch` statement that only wants to print out the error (as in most of our CLI tools).
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
- Coverage 92.48% 92.46% -0.03%
==========================================
Files 91 91
Lines 4939 4939
==========================================
- Hits 4568 4567 -1
- Misses 371 372 +1
Continue to review full report at Codecov.
|
JMMackenzie
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that it can be caught with a generic
catchstatement that only wants to print out the error (as in most of our CLI tools).