Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI problems #461

Merged
merged 20 commits into from
May 31, 2021
Merged

Fix CI problems #461

merged 20 commits into from
May 31, 2021

Conversation

elshize
Copy link
Member

@elshize elshize commented May 25, 2021

No description provided.

@elshize elshize changed the title Remove GCC 11 from Clang6 CI build Use libc++ when compiling with clang for CI May 25, 2021
@codecov
Copy link

codecov bot commented May 25, 2021 •
edited
Loading

Codecov Report

Merging #461 (bf14bc9) into master (9bb4d43) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          92       92           
  Lines        4997     4997           
=======================================
  Hits         4658     4658           
  Misses        339      339

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb4d43...bf14bc9. Read the comment docs.

@elshize elshize mentioned this pull request May 26, 2021
Open
@elshize elshize requested a review from JMMackenzie May 31, 2021 13:47
@elshize elshize self-assigned this May 31, 2021
@elshize
Copy link
Member Author

elshize commented May 31, 2021

@JMMackenzie I have done it!

I'm just using a docker image for clang-tidy to be able to reproduce when fails. I think we should do that to all tests eventually (#462).

Take another look at this and merge if looks good. Then we can finally take care of that other PR hopefully.

@elshize elshize changed the title Use libc++ when compiling with clang for CI Fix CI problems May 31, 2021
JMMackenzie
JMMackenzie approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@JMMackenzie JMMackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good idea, this looks good to me. I'll merge now and backtrack to the other PR.

@JMMackenzie JMMackenzie merged commit c63a312 into master May 31, 2021
@JMMackenzie JMMackenzie deleted the remove-gcc-11-from-clang-6 branch May 31, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMMackenzie JMMackenzie JMMackenzie approved these changes

Assignees

@elshize elshize

Labels
build system CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elshize @JMMackenzie