Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline to free function in header #466

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

elshize
Copy link
Member

@elshize elshize commented Jun 26, 2021

Must be inline or else fails when linking two translation units that both include it.

@elshize elshize added the bug Something isn't working label Jun 26, 2021
@elshize elshize self-assigned this Jun 26, 2021
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #466 (5fde3c5) into master (a28100d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   93.26%   93.23%   -0.03%     
==========================================
  Files          92       92              
  Lines        4926     4926              
==========================================
- Hits         4594     4593       -1     
- Misses        332      333       +1     
Impacted Files Coverage Δ
include/pisa/wand_data.hpp 85.55% <100.00%> (ø)
include/pisa/bit_vector.hpp 97.54% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a28100d...5fde3c5. Read the comment docs.

@elshize elshize merged commit fb4ef06 into master Jun 28, 2021
@elshize elshize deleted the inline-create-wand-data branch June 28, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants