Remove configuration.hpp #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elshize
force-pushed
the
remove-config
branch
4 times, most recently
from
7c04d16
to
76995b0
Compare
elshize
force-pushed
the
remove-config
branch
from
76995b0
to
4fe8d32
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 93.15% 93.21% +0.05%
==========================================
Files 91 91
Lines 4514 4508 -6
==========================================
- Hits 4205 4202 -3
+ Misses 309 306 -3 ☔ View full report in Codecov by Sentry. |
Removes the configuration file that defined how many bits to use for quantization. Instead, this is now configured by CLI options.
elshize
force-pushed
the
remove-config
branch
from
4fe8d32
to
5a3a5e5
Compare
JMMackenzie
approved these changes
Dec 11, 2023
Correct, no default because the option also says "do quantization", which means the default is no quantization bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the configuration file that defined how many bits to use for quantization. Instead, this is now configured by CLI options.
Fixes #322