This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Feature/api integration #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2021 03:03
…he registeration form, fix: changed locals with no nesting, local the rules for registeration
…bug in register form submission
imdhemy
suggested changes
Apr 9, 2021
| payload = { | ||
| ...payload, | ||
| client_id: '2', | ||
| client_secret: 'VqCDubRXgCjgSLvlwUdUMcJ8YYimoubzcKz7VX1L', |
There was a problem hiding this comment.
Client ID and secret should be grabbed from the env variables.
| payload = { | ||
| ...payload, | ||
| client_id: '2', | ||
| client_secret: 'VqCDubRXgCjgSLvlwUdUMcJ8YYimoubzcKz7VX1L', |
There was a problem hiding this comment.
Client ID and secret should be grabbed from the env variables.
src/services/index.js
Outdated
| return await axios.get(url) | ||
| } | ||
|
|
||
| export { post, get } |
There was a problem hiding this comment.
Why didn't you export an axios instance instead?
I suggest creating an axios instance with the default params/settings, then export it.
added 2 commits
April 9, 2021 19:29
…s itself, handeled it in auth services
abdelrahman-waziry
approved these changes
Apr 17, 2021
src/services/index.js
Outdated
| @@ -0,0 +1,11 @@ | |||
| const axios = require('axios') | |||
| axios.defaults.baseURL = 'http://localhost/api/v1' | |||
There was a problem hiding this comment.
Please consider fetching BASE_URL from the environment variables. also note that localhost should be changed in production.
abdelrahman-waziry
approved these changes
Apr 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
added services wrapper on axios
and applied the api services to the register and login.
fixed locals
added locals to login and rules
Why?
to be able to communicate with the api
Did you implemented automated tests for this PR?
not yet
Are the tests passing on Github actions?
Your answer...
Are the tests passing on your local machine?
yes
Fun facts:
added services/index that contains a wrapper for post and get functionalities and fixed part of the url.
in the services file in the modules implemented the login and the register functionalities and exported them to the modules and used them to communicate with the api