This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Feature/localisation #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imdhemy
reviewed
Apr 2, 2021
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
Kindly, fix the following typo:
- تغيير اللغة
- مستخدم سابق؟ قم بتسجيل الدخول
- أعد
I'm not sure about الاليكتروني and using المرور instead of السر
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
configuration and wrapper for i18next,
applying some locals on registration page
Why?
We need this for client side localizations and nesting locals into different modules/groups
Did you implemented automated tests for this PR?
no
Are the tests passing on Github actions?
Are the tests passing on your local machine?
yes
Fun facts:
a new module/folder that will contain json for each of the supported langs,
and each json can be nested into multiple objects for different components.
a js file that is acting as the wrapper for i18next that passes functions for localize/change language/ passing lang dropdown for lang change