Added --lda parameter for testing #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please, more details always help :) Especially when people find this PR later from the CHANGELOG, or there's a regression, etc. |
piskvorky
added a commit
that referenced
this pull request
Jul 27, 2015
Added --lda parameter for testing
|
@alexandreyc: can you prepare a short description (1-2 sentences) for what this PR fixed, when it's useful, how to use it? |
|
This PR adds |
|
Let's try to ping Matt Hoffman, the author of the VW implementation. Perhaps he knows more :) @heywhoah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This micro patch fixes a segmentation fault when VW is running in test only mode (tested on 7.7.0 and 8.0.0). This bug occurs on OS X (10.10.3). I can give you more details if needed.