load_word2vec_format(): remove init_sims() call #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gojomo Good point. Done. |
|
Great, thanks so much @svenkreiss ! |
piskvorky
added a commit
that referenced
this pull request
Dec 1, 2015
load_word2vec_format(): remove init_sims() call
|
@gojomo The note helps a lot, thanks. A 30 hours debugging until I saw this PR 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change as discussed in comment thread of PR #545.
This PR solves the same issue as #545, but applies an API breaking change to solve this problem properly.
Removes parameters
norm_onlyandinit_sims.The removal of the
init_sims()call changes the default behavior.