Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved dependency clash #177

Closed
wants to merge 1 commit into from
Closed

Conversation

JKutscha
Copy link
Contributor

Fix for #176.

Soloution: Remove bundle-version="2.0.0" from MANIFEST.MF because it caused an extra plug in import inside the feature.xml.

Copy link
Collaborator

@LorenzoBettini LorenzoBettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few doubts about this fix

@@ -228,6 +228,8 @@
<requires>
<import plugin="org.eclipse.core.runtime" version="3.11.1" match="compatible"/>
<import plugin="org.eclipse.jdt.core" version="3.11.2" match="compatible"/>
<import plugin="org.pitest.pitclipse.runner" version="2.0.0" match="compatible"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two are not required in the <requires> section since they are included as plugins or transitively through the included features of ours

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, the calculation of the Eclipse PDE is not working properly.

My steps to create this were:

  1. Open this file in Eclipse
  2. Switch to the dependency tab of the feature.xml
  3. Click on compute
    grafik

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it finds those dependencies and it adds them but they're useless and probably dangerous. Usually I never used that mechanism because it finds compile dependencies that are implicitly and automatically taken into consideration by P2 itself. This list should be used to specify runtime dependencies that cannot be computed automatically

@JKutscha
Copy link
Contributor Author

This seems not to fix the issue after a restart of eclipse, which I didn't test before.

@JKutscha JKutscha closed this Aug 11, 2021
@JKutscha JKutscha deleted the Dependency_cycle branch August 11, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants