Permalink
Commits on Apr 6, 2018
Commits on Nov 26, 2017
  1. Bump version to 1.4.1

    TingPing committed Nov 26, 2017
  2. Bind XF86AudioPause to userpause in keybinder

    JasonLG1979 authored and TingPing committed Nov 25, 2017
    Can't forget about keybinder...
  3. Listen for 'Pause' mediakeys action

    JasonLG1979 authored and TingPing committed Nov 23, 2017
  4. Fix up win-pos code a bit.

    JasonLG1979 authored and TingPing committed Nov 25, 2017
    1. Don't bother reading or setting the window position in Wayland.
    2. self.settings['win-pos'] can never be (None, None) but self.get_position() can be.
    3. Block the configure event handler when we move the window.
Commits on Nov 23, 2017
  1. Use Gtk.ComboBoxText for the audio quality combo and define the list …

    JasonLG1979 authored and TingPing committed Nov 22, 2017
    …in the UI file.
    
    This removes the need for all creation logic in PreferencesPithosDialog.py and negates the need for valid_audio_formats in data.py
Commits on Nov 22, 2017
  1. Default to highQuality

    JasonLG1979 authored and TingPing committed Nov 21, 2017
    As discussed in and fixes #538
Commits on Nov 20, 2017
  1. Only apply GNOME shell notification bug workaround to GNOME

    JasonLG1979 authored and TingPing committed Nov 20, 2017
    The bug has been reported upstream with a test case/app. See: https://bugzilla.gnome.org/show_bug.cgi?id=790636
  2. Work Around Broken Notification Servers (#541)

    JasonLG1979 authored and TingPing committed Nov 20, 2017
    Deepin's notification system is broken, see: https://github.com/gnumdk/lollypop/issues/1203
    This will stop exceptions by ignoring parameters and send a warning message about the broken signal.
    
    This also fixes a workaround for GNOME sending multiple redundant 'NotificationClosed' signals.
    
    The original workaround breaks actions in KNotifications because KNotifications does not increment the notification id's as they should. Instead each app has it's own id. Including signal_value in self._last_signal make it work for both.
    
    And covers about anything else that can go wrong in do_g_signal as gracefully as possible.
Commits on Nov 8, 2017
  1. Make Pandora error string more clear.

    JasonLG1979 authored and TingPing committed Nov 8, 2017
    as discussed in #535
Commits on Nov 7, 2017
  1. Fix line continuation in the Pandora error strings

    JasonLG1979 authored and TingPing committed Nov 7, 2017
    I noticed imcomplete error messages while debugging #534
Commits on Nov 4, 2017
Commits on Oct 9, 2017
  1. Fix logging.root.handlers getting reset and KeyError when using -last…

    JasonLG1979 authored and TingPing committed Oct 8, 2017
    …-logs command line arg
    
    
    fixes #518
  2. Fix TypeError in DBusServiceObject.py

    JasonLG1979 authored and TingPing committed Oct 8, 2017
    fixes #516
Commits on Sep 20, 2017
Commits on Sep 9, 2017
  1. Release 1.4.0

    TingPing committed Sep 8, 2017
Commits on Sep 8, 2017
  1. We can't use the GstAudio constants

    JasonLG1979 authored and TingPing committed Sep 4, 2017
    As much as I would prefer to use the GstAudio.AUDIO_RESAMPLER_QUALITY_MAX and GstAudio.AudioResamplerFilterMode.FULL constants, they don't exist in the version of Gstreamer that ships with *buntu 16.04. Trying to use them in *buntu 16.04 crashes Pithos.
    
    Instead just set "quality" and "sinc-filter-mode" to the values the constants would be if they existed...
Commits on Sep 3, 2017
  1. We create and delete stations but don't append or remove them from pa…

    JasonLG1979 authored and TingPing committed Sep 3, 2017
    …ndora.stations as we should. this fixes that.
  2. Ensure that the notification icon and journald logging plugin prefs w…

    JasonLG1979 authored and TingPing committed Sep 3, 2017
    …indows are not destroyed when they recieve a delete event
  3. Handle socket errors in pandora.py

    JasonLG1979 authored and TingPing committed Sep 3, 2017
Commits on Sep 2, 2017
  1. song.title should not be a property

    JasonLG1979 authored and TingPing committed Aug 31, 2017
    If song.title is a decorated property with a getter that means that the 1st thing to access it has to potentially do a blocking network call. It just so happens that the 1st thing to access song.title does so from the main thread. Doing blocking calls from the main thread is ofc bad. This instead moves checking the title to init to make sure that any blocking calls are done from a worker thread.
  2. Eq fixup

    JasonLG1979 authored and TingPing committed Sep 2, 2017
    Save a default state(eq flat) if there is no plugin['data'] value yet. Fixes an exception at the 1st run of the plugin.
Commits on Aug 30, 2017
  1. Sort Plugins Alphabetically

    JasonLG1979 authored and TingPing committed Aug 29, 2017
Commits on Aug 29, 2017
  1. Use trackGain from Pandora to fake a ReplayGain Plugin

    JasonLG1979 authored and TingPing committed Aug 26, 2017
    Use the ReplayGain Gstreamer Elements in conjunction with the trackGain from Pandora to create a "Auto Volume Normalization" plugin.
Commits on Aug 20, 2017
  1. Add a 10 Band Eq plugin

    JasonLG1979 authored and TingPing committed Aug 20, 2017
Commits on Aug 19, 2017
  1. We don't have to lie about being able to seek any longer

    JasonLG1979 authored and TingPing committed Aug 19, 2017
    The visibility of the position slider in https://github.com/JasonLG1979/gnome-shell-extensions-mediaplayer was decoupled from the CanSeek prop a while ago. As long as a Player provides a length in the metadata and can provide a valid postion the slider is visible. CanSeek determines if the slider is reactive. For Pithos that means the slider is visible but can't be moved by the user.
  2. Only emit metadata changed signals if we have to.

    JasonLG1979 authored and TingPing committed Jul 24, 2017
    Metadata is the most "expensive" property to deal with for clients. This cuts our Metadata updates to the bare minimum.
Commits on Aug 15, 2017
  1. Fix notification icon plugin loosing position

    JasonLG1979 authored and TingPing committed Aug 15, 2017
    This fixes the notification icon loosing position when it shows the window.