Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandora One, yet shows Commercial Break as song title occaisonally #289

Open
rickpage opened this issue Apr 9, 2016 · 5 comments
Open
Labels

Comments

@rickpage
Copy link

rickpage commented Apr 9, 2016

Second time seeing this, will update if I am more confident about how to reproduce. I have Pandora One, so I do not get commercials. But I have attached screen shot showing the song Land Down Under by the Avalanches was renamed to Commercial Advertisement by Pandora. Clicking Song Info shows the correct info by opening the Pandora song info page for that song.

The image attached attempts to show the difference.

Steps I will try later to reproduce:

  1. Suspend (running Ubuntu) while Pithos is running but paused.
  2. Wake up, log in, unpause pithos.
  3. Pithos will stop playing, sometimes in the middle of a song. I am thinking this is related to me using Suspend, and when it stops I change the station, plays normally. (This could be already documented issue, only have searched for commercial related issues before this post.)
  4. In this case I changed the station once, then changed the station almost right away to Avalanches
  5. First song right away shows Commercial Advertisement

Also, I doubt this should effect anything, but the song in question is only 0:34 seconds long. Closer to a commercial than a full song.

I'm experienced with Python, not so much with Pithos code yet, but I'm open to investigating this further if anyone has hints / direction / ideas. The only plugin im using is Notify. I have the Pandora One box checked. No proxy, no explicit content filter, Audio quality High.

pithosbugcommercial

@TingPing
Copy link
Member

TingPing commented Apr 9, 2016

Also, I doubt this should effect anything, but the song in question is only 0:34 seconds long. Closer to a commercial than a full song.

That would do it, currently it hardcodes a 45 second rule for ads as that was the easiest way to detect them.

@rickpage
Copy link
Author

rickpage commented Apr 9, 2016

Okay, that makes sense then. Would it suffice to change the check to < 45 s AND no song title present (or whatever other criteria we can count on - if any)? Where would I look for this code, what file(s)? I'll make the change and test if I know where to look.

@TingPing
Copy link
Member

TingPing commented Apr 9, 2016

Would it suffice to change the check to < 45 s AND no song title present (or whatever other criteria we can count on - if any)?

That's the problem, it shows the title of a normal song. I think the pianobar project implemented some better ad checks but I am not sure. We handle this in pithos.py:check_if_song_is_ad().

@JasonLG1979
Copy link
Collaborator

There might be something useful in https://github.com/PromyLOPh/pandora-apidoc/blob/master/json/ads.rst

But a good 1st step would be to just disable ad checking for Pandora one accounts.

@JasonLG1979
Copy link
Collaborator

The key 'might' be adToken?

@TingPing TingPing added the bug label Jul 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants