-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandora One, yet shows Commercial Break as song title occaisonally #289
Comments
That would do it, currently it hardcodes a 45 second rule for ads as that was the easiest way to detect them. |
Okay, that makes sense then. Would it suffice to change the check to < 45 s AND no song title present (or whatever other criteria we can count on - if any)? Where would I look for this code, what file(s)? I'll make the change and test if I know where to look. |
That's the problem, it shows the title of a normal song. I think the pianobar project implemented some better ad checks but I am not sure. We handle this in |
There might be something useful in https://github.com/PromyLOPh/pandora-apidoc/blob/master/json/ads.rst But a good 1st step would be to just disable ad checking for Pandora one accounts. |
The key 'might' be adToken? |
Second time seeing this, will update if I am more confident about how to reproduce. I have Pandora One, so I do not get commercials. But I have attached screen shot showing the song Land Down Under by the Avalanches was renamed to Commercial Advertisement by Pandora. Clicking Song Info shows the correct info by opening the Pandora song info page for that song.
The image attached attempts to show the difference.
Steps I will try later to reproduce:
Also, I doubt this should effect anything, but the song in question is only 0:34 seconds long. Closer to a commercial than a full song.
I'm experienced with Python, not so much with Pithos code yet, but I'm open to investigating this further if anyone has hints / direction / ideas. The only plugin im using is Notify. I have the Pandora One box checked. No proxy, no explicit content filter, Audio quality High.
The text was updated successfully, but these errors were encountered: