Fix libnotify >= 0.7.6 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libnotify 0.7.6 changed the number of `Notification.add_action` arguments (when called from python) from 6 to 5. The 6th argument should never have been exposed and this commit hacks previous versions of libnotify (`< 0.7.6`) to support 5 arguments. Bug report: https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/1223401
|
Works for me. Does it work for you @gregsheremeta since you were the one who commited this change. |
|
Worked great -- thanks :) |
|
@Stebalien You check for 0.7.6, some users on that version report it is still broken, while I am on that version (in fedora) and it works. They are all on Ubuntu which I know you don't use but somebody needs to fix this before release, or else we will just have to revert this commit since we already had a work around in place that seemed(?) to work. Their libnotify package contains a patch called revert_api_change.patch. Wonder if thats the cause... EDIT: Confirmed Debian broke it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libnotify 0.7.6 changed the number of
Notification.add_actionarguments (when called from python) from 6 to 5. The 6th argument should
never have been exposed and this commit hacks previous versions of
libnotify (
< 0.7.6) to support 5 arguments.Bug report: https://bugs.launchpad.net/ubuntu/+source/libnotify/+bug/1223401