Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for API version in Unbind operation #102

Closed
desislavaa opened this issue Mar 16, 2020 · 2 comments
Closed

Check for API version in Unbind operation #102

desislavaa opened this issue Mar 16, 2020 · 2 comments
Labels

Comments

@desislavaa
Copy link
Contributor

Hello all,

There is this check for API version > 2.14 for async unbind operations which fails the request when accepts_incomplete is true.

accepts_incomplete is not supported in versions <14, so I understand the point of the check.
However, in my use case, the broker is now deployed on K8S and the Service Catalog sends an async request with API version header 2.13. The service catalog uses the kubernetes-sigs/go-open-service-broker-client package and here we can see it uses the default configuration of the client lib, where the latest API version is 2.13.

I've also noticed that the check is not executed for deprovision, which is inconsistent.

What do you think about removing the check for now and rely more on the value passed as accepts_incomplete? If you agree, I can make the PR.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/171813174

The labels on this github issue will be updated when the story is started.

@FelisiaM
Copy link
Contributor

Hi @desislavaa

Sorry for the delay - We removed the check and will be releasing soon

Thanks
Felisia & @kirederik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants