fix: ensure SHA1 field is not empty

Authored-by: Carlos Iriarte <ciriarte@users.noreply.github.com>
pivotal-cf · Nov 9, 2021 · 7fba034 · 7fba034
1 parent 551df77
commit 7fba034
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/internal/commands/cache_compiled_releases.go b/internal/commands/cache_compiled_releases.go
@@ -133,10 +133,6 @@ func (cmd CacheCompiledReleases) Execute(args []string) error {
 		} else {
 			cmd.Logger.Printf("found %s/%s in %s\n", rel.Name, rel.Version, remote.RemoteSource)
 		}
-		err = updateLock(lock, remote)
-		if err != nil {
-			return fmt.Errorf("failed to update lock file: %w", err)
-		}
 	}
 
 	switch len(nonCompiledReleases) {

diff --git a/internal/commands/cache_compiled_releases_test.go b/internal/commands/cache_compiled_releases_test.go
@@ -201,6 +201,7 @@ func TestCacheCompiledReleases_Execute_when_one_release_is_cached_another_is_alr
 			},
 			RemoteSource: "cached-compiled-releases",
 			RemotePath:   "lemon-3.0.0-alpine-9.0.0",
+			SHA1:         "012ed191f1d07c14bbcbbc0423d0de1c56757348",
 		}, nil
 	})
 
@@ -256,7 +257,6 @@ func TestCacheCompiledReleases_Execute_when_one_release_is_cached_another_is_alr
 			Name:    "lemon",
 			Version: "3.0.0",
 		},
-		SHA1:         "012ed191f1d07c14bbcbbc0423d0de1c56757348",
 		RemoteSource: "cached-compiled-releases",
 		RemotePath:   "lemon-3.0.0-alpine-9.0.0",
 	}))