fix: Updated logic on when to bake Kilnfile arguments #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bake arguments from kilnfile only when the stub releases flag is not set. - This is causing TAS PRs checks to fail as currently for stub releases arguments are not needed. Authored-by: Ramkumar Vengadakrishnan <ramkumar.vengadakrishnan@broadcom.com>
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
we have a variable bootstrapping problem when we try to load variables before interpolating Kilnfiles Ram and I noticed the stemcell service does not do interpolation so we can also skip it for bake config this also adds a bit more testing for bake configs
Co-authored-by: Ramkumar Vengadakrishnan <ramkumar.vengadakrishnan@broadcom.com>
crhntr
force-pushed
the
fix/tas-pr-unit-test-failure
branch
from
24b80c3
to
8211c78
Compare
- Also fixed --help argument for re-bake command Authored-by: Ramkumar Vengadakrishnan <ramkumar.vengadakrishnan@broadcom.com>
crhntr
approved these changes
Mar 26, 2024
pabloarodas
approved these changes
Mar 26, 2024
|
Installed version locally and it works now to generate a tile with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored-by: Ramkumar Vengadakrishnan ramkumar.vengadakrishnan@broadcom.com