Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

Lets not Let's #77

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Lets not Let's #77

merged 1 commit into from
Aug 24, 2018

Conversation

cobyalmond
Copy link
Contributor

@cobyalmond cobyalmond commented Aug 23, 2018

I'm the grammar police.

Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have made this pull request to the master branch

  • I have run all the API unit tests using bundle exec rake from the /api submodule.

  • I have run all the WEB unit tests using gulp spec-app from the /web submodule.

  • I have run all the acceptance tests using gulp local-acceptance from the /web submodule.

  • I have added the copyright headers to each new file added

I'm the grammar police.
@seadowg
Copy link
Contributor

seadowg commented Aug 24, 2018

👍

@seadowg seadowg merged commit 32ea46b into vmware-archive:master Aug 24, 2018
@seadowg seadowg added this to the 2.5.0 milestone Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants