-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piwik Mobile to display Custom Variables values when a Custom var name is clicked #2654
Comments
I'd like to work on this feature. Also want to display a subtable for pages. For example clicking on '/support' opens '/support/contact', '/support/faq', ... Therefore the api has to return which API to call when a row is clicked (as you mentioned) and maybe which parameter to pass. |
see also #2742 |
(In [6500]) refs #2654 refactored TableView and StatisticList. Also fixed some possible memory leaks |
(In [6501]) refs #2654 prevent cleanup from list of reports window on iPad |
Moving to Piwik core so that we hopefully get going in the next 2 months on this :) |
Thanks Benaka for your work on this and unblocking Thomas to continue improving Piwik Mobile, to display the very useful sub-table analytics data! |
(In [6880]) refs #2654 a first working version. still have to do lots of tests and detect possible memory leaks |
(In [6881]) refs #2654 make sure cleanup continues even if there are errors |
(In [6889]) refs #2654 make sure tableview eventlistener will be added only once |
(In [6896]) refs #2654 make sure the label has always the same left position even if hasChild is true |
(In [6898]) refs #2654 display subtables only if Piwik version is 1.8.4 or newer |
(In [6903]) refs #2654 request piwik version max once a day |
(In [6904]) refs #2654 do not overwrite an already existing version if something went wrong during request |
(In [6906]) refs #2654 track piwik version as a page custom variable |
Excellent !! Users will love this... such an important feature and will expose critical data in the mobile app. Kuddos Thomas and Benaka :) Some questions;
|
Sure! I'll add some screenshots. You'll notice that the screenshot of the subtable don't display a "websites selector". This is because the subtable report won't exist in another website. Therefore it makes no sense to be able to switch the website there. It would result in an error. I don't leave the parent table visible but instead open a new window to display the subtable. Everything else would be really tricky / hard to implement with Titanium. In addition it has some advantages to do it this way. Users can view the graph, change date/metric, better readable, if a subtable had subtables it would be possible to open even those :) I think it's also more "mobile-like" |
Attachment: |
Attachment: |
(In [6915]) refs #2654 make sure piwik server version will be updated if a user changes an account |
Good, on the "Back" button when viewing the subtable, could you write the |
I had wrote the name of the parent report ie "Custom Variables" instead of "Back" in a first version and then replaced it with "Back". There is often not enough space on a mobile device. Shall I do it though? It definitely makes sense on the iPad, not sure for iPhone. Maybe it is indeed better to have a shortened title instead of only "Back". I'll attach another screenshot. |
Attachment: |
(In [6919]) refs #2654 display name of parent report instead of only Back |
I thought about it... I think it's definitely better to write the name of the parent report instead of "Back". |
Definitely, however, can you please split 2 words on 2 lines as it would look much better and use less width! |
It's not possible to split text into multiple lines in header. Multiple lines are not supported by Titanium there and I'm pretty sure also not by iOS. It's also not possible to specify the width or height of the back button. |
Ok thanks for confirming - it's nice as it is. |
When clicking on a row (Custom var name) Piwik mobile would show a subtable with values (custom var values)
Requested in: http://forum.piwik.org/read.php?2,76375
Piwik Mobile requirements:
In this case, the "swipe / back" gesture would come back to the previous "Custom variable names" report.
Both solutions would be fine IMO... whatever is easiest/best could be done?
There are also "Piwik core" requirements to make this feature work:
Piwik Metadata API also returns which API to call when a row is clicked eg. CustomVariables.getCustomVariablesValuesFromNameId
Piwik metadata should support the API call CustomVariables.getCustomVariablesValuesFromNameId currently unsupported
Then piwik mobile would call metadata API for this API method which would return the whole report for the row clicked, as a standard Piwik report
Any feedback please post a comment!
The text was updated successfully, but these errors were encountered: