Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Convert core and plugin translations to simple json format #4086

Closed
halfdan opened this Issue · 9 comments

3 participants

@halfdan
Collaborator

As discussed during the meetup, we want to move translation files away from PHP arrays and use json files instead.

@anonymous-piwik-user

In ba58259: Converted PHP translations to nested JSON

refs #4086

@anonymous-piwik-user

In 058c83e: Adjust Piwik_Translate function to handle nested translation array
Adjust Translate class to properly load .json translation into array
Adjust JavaScript translation filter
Adjust plugins manager to load plugin translations properly

refs #4086

@sgiehl
Collaborator

In 740854c: refs #4086 removed trailing/leading whitespaces from english translations

@sgiehl
Collaborator

In 5dba66b: refs #4086 fixed translationwriter to work with json files

@sgiehl
Collaborator

In 4be8840: refs #4086 fixed languagesmanager tests;
now thirdparty translations will be removed

@sgiehl
Collaborator

In 8e1a4f0: refs #4086 adjusted automatic updatescript to work with new json format

@sgiehl
Collaborator

In 5690a76: refs #4086 updated language files; third party plugins were removed

@anonymous-piwik-user

In 0499b17: Downgrade json_encode to 5.3 for now (ommit JSON_UNESCAPED_UNICODE and JSON_PRETTY_PRINT)
Adjust TranslationWriterTest

fixes #4086

@anonymous-piwik-user

In 42893f5: Fixes failing tests for non-translated translation keys. Thanks to @tsteur for spotting this!

refs #4086

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone
@halfdan halfdan self-assigned this
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Converted PHP translations to nested JSON
refs #4086
ba58259
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Adjust Piwik_Translate function to handle nested translation array
Adjust Translate class to properly load .json translation into array
Adjust JavaScript translation filter
Adjust plugins manager to load plugin translations properly

refs #4086
058c83e
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@sgiehl sgiehl refs #4086 fixed languagesmanager tests;
now thirdparty translations will be removed
4be8840
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Downgrade json_encode to 5.3 for now (ommit JSON_UNESCAPED_UNICODE an…
…d JSON_PRETTY_PRINT)

Adjust TranslationWriterTest

fixes #4086
0499b17
@sabl0r sabl0r referenced this issue from a commit in sabl0r/piwik
@halfdan halfdan Fixes failing tests for non-translated translation keys. Thanks to @t…
…steur for spotting this!

refs #4086
42893f5
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.