Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Fix buttons in ImageInspector #117

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Conversation

cpvannier
Copy link
Member

@cpvannier cpvannier commented Feb 8, 2024

Issue

Fixes #116

Description

  • Open object card when clicking on editing button (since as of feat(front): Create fixed size sections for Ground truth and Model run  #87, object cards are closed by default)
  • Add missing button tooltips (scene features, object visibility, object highlighting, object card toggle, bounding box and mask toggles)
  • Fix existing button tooltips consistency (first letter should be uppercase)

@cpvannier cpvannier added enhancement New feature or request scope: front Related to Pixano frontend labels Feb 8, 2024
@cpvannier cpvannier added this to the Pixano 0.5.0 milestone Feb 8, 2024
@cpvannier cpvannier self-assigned this Feb 8, 2024
Copy link
Contributor

@timothee-LJN timothee-LJN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure consistency I'd reckon the force the capitalization of the tooltipIconContent with the following

    <Tooltip.Content>
      <p class="first-letter:uppercase">foo</p>
    </Tooltip.Content>

in TooltipIconButton.svelte (line 39)

@cpvannier
Copy link
Member Author

cpvannier commented Feb 8, 2024

@timothee-LJN Adding class="first-letter:uppercase" to the <p> element inside <Tooltip.Content> seems to produce weird padding issues.

Without class="first-letter:uppercase" :
image

With class="first-letter:uppercase" :
image

Quite strange...

@timothee-LJN
Copy link
Contributor

this weird indeed. I don't reproduce on my computer. I've no idea where it could come from!

@cpvannier
Copy link
Member Author

Ok, it's just a Firefox issue. It works as expected in Chrome.

The <p> element size if defined as if the whole word was in uppercase instead of just the first letter.

I am going to merge this PR as is for now then.

@cpvannier cpvannier merged commit d1b4da0 into develop Feb 8, 2024
5 checks passed
cpvannier added a commit that referenced this pull request Feb 15, 2024
* fix(front): Fix tooltips case in Inspector

* fix(front): Add tooltip to object visibility button in Inspector

* fix(front): Open object card automatically when editing

As of #87, object cards are closed by default. Clicking the editing tool should open the object card automatically to display the editable features

* fix(front): Add tooltip for toggling object card

* fix(front): Add tooltips for box and mask toggles

* fix(front): Add tooltip for object highlighting

* fix(front): Improve object visibility tooltips

* fix(front): Add tooltip for editing scene features
@cpvannier cpvannier deleted the fix/inspector_buttons branch February 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scope: front Related to Pixano frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix buttons in ImageInspector
3 participants