feat(front): Create fixed size sections for Ground truth and Model run #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothee-LJN
added
enhancement
|
update : following a call with lead design Janro, the following changes have been added :
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
BertrandRenault
approved these changes
Feb 5, 2024
cpvannier
changed the title
|
@cpvannier I've made the changes your requested. |
cpvannier
approved these changes
Feb 5, 2024
cpvannier
added a commit
that referenced
this pull request
Feb 8, 2024
As of #87, object cards are closed by default. Clicking the editing tool should open the object card automatically to display the editable features
This was referenced Feb 8, 2024
cpvannier
added a commit
that referenced
this pull request
Feb 8, 2024
* fix(front): Fix tooltips case in Inspector * fix(front): Add tooltip to object visibility button in Inspector * fix(front): Open object card automatically when editing As of #87, object cards are closed by default. Clicking the editing tool should open the object card automatically to display the editable features * fix(front): Add tooltip for toggling object card * fix(front): Add tooltips for box and mask toggles * fix(front): Add tooltip for object highlighting * fix(front): Improve object visibility tooltips * fix(front): Add tooltip for editing scene features
cpvannier
pushed a commit
that referenced
this pull request
Feb 15, 2024
#87) * refactor(front): Change naming for image inspector components * feat: Separate ModelRun and GT in equal sections * feat(front): Do not show preannotation if no object to pre annotate * feat(front): Make object card chevron lighter * feat(front): Hide model run section if empty * feat(front): Add number of item on section level * feat(front): Harmonize font weight for inspector title * refactor(front): Rename objectItem to ObjectCard * feat(front): Improve card display * feat: Show object card icons only on hover or when card is open * feat(front): Focus on pre annotation when its active * fix(front): Improve scrolling on large device * feat(front): Filter model run objects * style: Remove console.log
cpvannier
added a commit
that referenced
this pull request
Feb 15, 2024
* fix(front): Fix tooltips case in Inspector * fix(front): Add tooltip to object visibility button in Inspector * fix(front): Open object card automatically when editing As of #87, object cards are closed by default. Clicking the editing tool should open the object card automatically to display the editable features * fix(front): Add tooltip for toggling object card * fix(front): Add tooltips for box and mask toggles * fix(front): Add tooltip for object highlighting * fix(front): Improve object visibility tooltips * fix(front): Add tooltip for editing scene features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #80
Change description
question
@jrabary Model run objects are filtered only in the inspector, which means that they are still visible on the image and toggling visibility is for all model run. Shall I change that? (it would make sense I guess, but I prefer to get confirmation before coding).
not done