Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Support for Uploading Local Tool Results Instead of Fetching Results #30

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gilday
Copy link
Contributor

@gilday gilday commented Jul 8, 2024

When using the file input with any of the tools that support automatically fetching results, the action would ignore the file input and instead attempt to automatically fetch the results. The intention is for the file input to replace the automatic fetching.

Since we introduced two separate result schemas for Sonar (issues and hotspots), using local Sonar results includes more friction than other tools. When using file, the user must specify whether the local file is a Sonar issues file or Sonar security hotspots file.

/close #work

…sults

When using `file` with any of the tools that support automatically
fetching results, the action would ignore the `file` input and instead
attempt to automatically fetch the results. The intention is for the
`file` input to replace the automatic fetching.

This causes some friction with Sonar, since we introduced two separate
result schemas for Sonar (issues and hotspots). When using `file`, the
user must specify whether the local file is a Sonar issues file or Sonar
security hotspots file.

/close #work
@gilday gilday force-pushed the iss-1520/support-sonar-results-from-local-file branch from 5627a54 to d9ce08e Compare July 9, 2024 00:22
@gilday gilday marked this pull request as ready for review July 9, 2024 00:41
@gilday gilday requested a review from drdavella July 9, 2024 00:41
@gilday gilday merged commit a764691 into main Jul 9, 2024
1 check passed
@gilday gilday deleted the iss-1520/support-sonar-results-from-local-file branch July 9, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants