Skip to content

Commit

Permalink
So it look like gnome team decided to remove StageInputMode in commit…
Browse files Browse the repository at this point in the history
… 8d1ed9f88ac1574588b566b1e483f14ea455d169 for god only knows what reason as the documentation do not mention it.

In order to help his fellow dev, the great gnome team decided to put "messageTray: Port to GrabHelper" as commit message. With such clarity, it is obvious to everybody what the migration path should be and documenting any of this is a comprehensive manner would be a complete waste of time.

After digging for a while, I have to declare myself defeated by the gnome team and simply skip the check altogether, hopping for it to not have dramatic effect.

Once again, gnome didn't failled its reputation by providing a great user interface and backing it up by the most dubious engineering and not documenting any of it.
  • Loading branch information
deadalnix committed Aug 28, 2014
1 parent de4ffd1 commit 4fb6409
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions pixel-saver@deadalnix.me/app_menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,10 @@ function changeActiveWindow(win) {
* Focus change
*/
function onFocusChange() {
if (!Shell.WindowTracker.get_default().focus_app &&
global.stage_input_mode == Shell.StageInputMode.FOCUSED) {
let input_mode_check = (global.stage_input_mode === undefined)
? true
: global.stage_input_mode == Shell.StageInputMode.FOCUSED;
if (!Shell.WindowTracker.get_default().focus_app && input_mode_check) {
// If the app has just lost focus to the panel, pretend
// nothing happened; otherwise you can't keynav to the
// app menu.
Expand Down

0 comments on commit 4fb6409

Please sign in to comment.