Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension fails to load in GNOME 3.32 #195

Closed
ronjouch opened this issue Mar 16, 2019 · 7 comments
Closed

Extension fails to load in GNOME 3.32 #195

ronjouch opened this issue Mar 16, 2019 · 7 comments

Comments

@ronjouch
Copy link

ronjouch commented Mar 16, 2019

The usual! 馃槃, GNOME isn't exactly friendly with extensions backwards compat, eh 馃槙.

Here are the errors I see in journalctl:

gnome-shell[19665]: JS ERROR: TypeError: label is undefined
                    onAppMenuHover/tooltipDelayCallbackID<@/home/ronj/.local/share/gnome-shell/extensions/pixel-saver@deadalnix.me/app_menu.js:116:8
gnome-shell[19665]: [pixel-saver]: 'appmenu' is not a valid button.
gnome-shell[19665]: JS WARNING: [/home/ronj/.local/share/gnome-shell/extensions/pixel-saver@deadalnix.me/decoration.js 216]: assignment to undeclared variable success
gnome-shell[19665]: JS WARNING: [/home/ronj/.local/share/gnome-shell/extensions/pixel-saver@deadalnix.me/decoration.js 216]: assignment to undeclared variable pid
gnome-shell[19665]: Some code called array.toString() on a Uint8Array instance. Previously this would have interpreted the bytes of the array as a string, but that is nonstandard. In the future this will return the bytes as comma-separated digits. For the time being, the old behavior has been preserved, but please fix your code anyway to explicitly call ByteArray.toString(array).
                    (Note that array.toString() may have been called implicitly.)
                    0 getOriginalState() ["/home/ronj/.local/share/gnome-shell/extensions/pixel-saver@deadalnix.me/decoration.js":154]
                    1 setHideTitlebar() ["/home/ronj/.local/share/gnome-shell/extensions/pixel-saver@deadalnix.me/decoration.js":203]
                    2 onWindowAdded/<() ["/home/ronj/.local/share/gnome-shell/extensions/pixel-saver@deadalnix.me/decoration.js":297]

I'm using the latest version available on extensions.gnome.org.

EDIT: new extension https://extensions.gnome.org/extension/1732/gtk-title-bar/ (github) seems to do the job.

@Norbert01
Copy link

Norbert01 commented Mar 16, 2019

From a no-title-bar (similar extension) request:

franglais125/no-title-bar#113

In GNOME 3.32 _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED is gone: https://gitlab.gnome.org/GNOME/mutter/merge_requests/221

They say that extensions should use _MOTIF_WM_HINTS instead.

@jonian
Copy link

jonian commented Mar 17, 2019

I have fixed this issue in my extension (unite) and this is the final solution:
https://github.com/hardpixel/unite-shell/blob/master/unite%40hardpixel.eu/modules/windowDecoration.js#L86

More info on possible problems using _MOTIF_WM_HINTS:
https://gitlab.gnome.org/GNOME/mutter/merge_requests/221#note_461106

@feimosi
Copy link

feimosi commented Mar 24, 2019

For me it fails with the following error:

TypeError: global.screen is undefined

@mahdiG
Copy link

mahdiG commented Apr 21, 2019

@feimosi
#178 (comment)
You have to change global.screen to global.workspace_manager I guess.
But the problem is in 3.32 the extension still doesn't work despite the change and I get errors similar to @ronjouch

@ronjouch
Copy link
Author

ronjouch commented Apr 23, 2019

In addition to already-mentioned extension "Unite" (which works but may be too invasive, as it tries to replicate Ubuntu's Unity feel), I just found extension GTK Title Bar - Remove Title Bar for non-GTK Software / https://extensions.gnome.org/extension/1732/gtk-title-bar/ , which is weirdly named but seems to do the job very well under 3.32 馃檪.

@matthijskooijman
Copy link
Contributor

Note that the global.screen error first appears in 3.30, is the subject of #195 but is not released yet (#177).

@tallero
Copy link
Collaborator

tallero commented Sep 3, 2019

For me it fails with the following error:

TypeError: global.screen is undefined

Install the application not from extensions website (see #177) but from this repository.

In addition to already-mentioned extension "Unite" (which works but may be too invasive, as it tries to replicate Ubuntu's Unity feel), I just found extension GTK Title Bar - Remove Title Bar for non-GTK Software / https://extensions.gnome.org/extension/1732/gtk-title-bar/ , which is weirdly named but seems to do the job very well under 3.32 .

GNOME 3.32 has been merged in #199.

@tallero tallero closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants