Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] TYPO3 update to 12.4.10 on PHP 8.2 leads to Fatal error #111

Closed
Bussmeyer opened this issue Feb 14, 2024 · 3 comments · Fixed by #113
Closed

[TASK] TYPO3 update to 12.4.10 on PHP 8.2 leads to Fatal error #111

Bussmeyer opened this issue Feb 14, 2024 · 3 comments · Fixed by #113

Comments

@Bussmeyer
Copy link

Bussmeyer commented Feb 14, 2024

Describe the bug
With the TYPO3 update https://get.typo3.org/release-notes/12.4.10 on a PHP 8.2 setup the Symfony Console switched from 6.4 to 7.0
TYPO3/typo3@b03970d94d

The method signatures of some of the methods changed.
This leads to the following error message in all requests (frontend and backend)

To Reproduce
Steps to reproduce the behavior:

  1. Update TYPO3 from 12.4.9 to 12.4.10
  2. Open any page
  3. See error

Fatal error: Declaration of Pixelant\Interest\Command\UpdateCommandController::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /var/www/html/.build/vendor/pixelant/interest/Classes/Command/UpdateCommandController.php on line 47

Expected behavior
All requests should work without errors.

Desktop (please complete the following information):

  • OS: macOS, ddev
  • Browser: all
  • Version: all
@Bussmeyer Bussmeyer changed the title [BUG] TYPO3 update to 12.4.10 leads to Fatal error [BUG] TYPO3 update to 12.4.10 on PHP 8.2 leads to Fatal error Feb 14, 2024
@Bussmeyer Bussmeyer changed the title [BUG] TYPO3 update to 12.4.10 on PHP 8.2 leads to Fatal error [TASK] TYPO3 update to 12.4.10 on PHP 8.2 leads to Fatal error Feb 14, 2024
Bussmeyer added a commit to Bussmeyer/interest that referenced this issue Feb 14, 2024
@mabolek
Copy link
Contributor

mabolek commented Feb 14, 2024

Hi @Bussmeyer!

Thank you for reporting this.

I guess this should be fixed by specifying Symfony Console as an explicit requirement, and only for v6.4, not allowing v7.

@Bussmeyer
Copy link
Author

Hi @mabolek, sounds like a solution as well. Would you implement the fix and we close #112?

@mabolek
Copy link
Contributor

mabolek commented Feb 14, 2024

Yup, @Bussmeyer. I'll do that.

MattiasNilsson pushed a commit that referenced this issue Feb 26, 2024
….4.11 (#113)

* [BUGFIX] Prevent incompatibility with symfony/console v7

Resolves #111

* [TASK] Add earlier symfony/console versions

* [TASK] Don't require reactions for v13

* Revert "[TASK] Don't require reactions for v13"

This reverts commit 85eceb2.

* [TASK] Don't require reactions for v13

* [TASK] Remove unnecessary null check

* [WIP] Lock Composer to 2.2.22

* Revert "[WIP] Lock Composer to 2.2.22"

This reverts commit 2330fd8.

* [TASK] Don't set PID for sys_file

* [TASK] Raise version to 2.1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants