Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Compatibility with changes in TYPO3 11.5.35, 12.4.10, and 12.4.11 #113

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

mabolek
Copy link
Contributor

@mabolek mabolek commented Feb 14, 2024

  • Prevents the use of symfony/console v7, introduced in TYPO3 v12.4.10.
  • PID will no longer be set for operations on the sys_file table. Modifying this table through DataHandler was blocked in TYPO3 v11.5.35 and v12.4.11 due to a security issue. DataHandler will throw an error if sys_file fields are set, so this extension should not add any such fields to the data array.

Resolves #111

@Bussmeyer
Copy link

Hi @mabolek, I hope your doing good? Anything I should do from my end? Best, Thomas

@mabolek
Copy link
Contributor Author

mabolek commented Feb 21, 2024

Hi @Bussmeyer! No action necessary from your end. This PR is currently working, but it also fixes permission issues introduced with the latest security update. I'm currently exploring the best solution, and might change it to disallow all custom data on the sys_file table instead of just not setting the PID.

@mabolek mabolek changed the title [BUGFIX] Prevent incompatibility with symfony/console v7 [BUGFIX] Compatibility with changes in TYPO3 11.5.35, 12.4.10, and 12.4.11 Feb 24, 2024
@mabolek
Copy link
Contributor Author

mabolek commented Feb 24, 2024

@MattiasNilsson Great if you can review this PR, squash merge, and release as version 2.1.1. I have already changed the version in ext_emconf.php.

@MattiasNilsson MattiasNilsson merged commit f082246 into master Feb 26, 2024
46 checks passed
@MattiasNilsson MattiasNilsson deleted the 111-incompatible-console-version branch February 26, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] TYPO3 update to 12.4.10 on PHP 8.2 leads to Fatal error
3 participants