Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update v2 extensions to v3 when opened in Page Editor #2285

Closed
BLoe opened this issue Jan 3, 2022 · 0 comments · Fixed by #2298
Closed

Automatically update v2 extensions to v3 when opened in Page Editor #2285

BLoe opened this issue Jan 3, 2022 · 0 comments · Fixed by #2298
Assignees
Labels
medium T-shirt sizing page editor user experience Improve the user experience (UX)
Milestone

Comments

@BLoe
Copy link
Collaborator

BLoe commented Jan 3, 2022

General cases:

  • If it’s a @ + identifier, convert to var
  • If there’s a {{ or {% convert to the template engine

A corner case we don’t need to support is blueprints with multiple extensions. (Because you can’t just update the runtime of one of the extensions).

UX:
Open something that is v2, and it has a message: “The Page Editor no longer supports bricks created for runtime v2. We’ve automatically tried converting this extension to use v3. Read more about this change and troubleshooting here (link to a notion page)”

@BLoe BLoe added user experience Improve the user experience (UX) page editor medium T-shirt sizing labels Jan 3, 2022
@BLoe BLoe self-assigned this Jan 3, 2022
@twschiller twschiller added this to the 1.5.0 milestone Jan 4, 2022
twschiller added a commit that referenced this issue Jan 6, 2022
twschiller added a commit that referenced this issue Jan 6, 2022
@BLoe BLoe closed this as completed in #2298 Jan 7, 2022
BLoe added a commit that referenced this issue Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium T-shirt sizing page editor user experience Improve the user experience (UX)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants