Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slice 1: Add starter mod sidebar panels to closedTabs on install #8076

Closed
grahamlangford opened this issue Mar 27, 2024 · 0 comments · Fixed by #8083
Closed

Slice 1: Add starter mod sidebar panels to closedTabs on install #8076

grahamlangford opened this issue Mar 27, 2024 · 0 comments · Fixed by #8083
Assignees
@grahamlangford
Labels
enhancement New feature or request user experience Improve the user experience (UX)

Comments

@grahamlangford
Copy link
Collaborator

https://www.notion.so/pixiebrix/Phase-1-Showing-Mod-Launcher-on-first-side-panel-0f589beaa0514541a61be54a1c2fdeae?pvs=4#b396d71419d14171af4e154a9b903390
@grahamlangford grahamlangford self-assigned this Mar 27, 2024
This was referenced Mar 27, 2024
Merged
Merged
Merged
@grahamlangford grahamlangford linked a pull request Mar 28, 2024 that will close this issue
#8076: add starter mod sidebar panels to closedtabs on install #8083
Merged
3 tasks
@twschiller twschiller added enhancement New feature or request user experience Improve the user experience (UX) labels Mar 30, 2024
grahamlangford added a commit that referenced this issue Apr 1, 2024
@grahamlangford @fungairino @BLoe
#8076: add starter mod sidebar panels to closedtabs on install (#8083)
83fd174 
* get sidebar state in background

* starter mods sidebar panels are closed on install

* fix imports

* add sidebarStorage to strictNullChecks

* adds tests for sidebarStorage

* adds more test coverage

* add tests for getModComponentIdsForModComponentDefinitions

* renaming

* update factory to support overriding starterBrickType

* revert factory changes

* lint fixes

* add troubleshooting section to e2e tests readme (#8095)

* ensure we capture events in selection menu handlers (#8096)

* pr-related fixes

* Update src/background/starterMods.ts

Co-authored-by: Ben Loe <below413@gmail.com>

* fix types

---------

Co-authored-by: Eduardo Fungairino <eduardo@pixiebrix.com>
Co-authored-by: Ben Loe <below413@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grahamlangford grahamlangford

Labels
enhancement New feature or request user experience Improve the user experience (UX)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#8076: add starter mod sidebar panels to closedtabs on install pixiebrix/pixiebrix-extension
2 participants
@twschiller @grahamlangford