-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unavailable deployments not uninstalled on Extension Console refresh #8131
Labels
bug
Something isn't working
Comments
twschiller
changed the title
Unavailable deployments not uninstalled when on Extension Console refresh
Unavailable deployments not uninstalled on Extension Console refresh
Apr 2, 2024
@grahamlangford based on @mnholtz investigation these 2 issues likely have the same root cause and should likely be worked on together: #7475 |
3 tasks
mnholtz
added a commit
that referenced
this issue
Apr 5, 2024
* refactor rename extensions -> activatedModComponents * refactor rename uninstallAllDeployments -> deactivateAllDeployedMods * refactor rename vars in deactivateAllDeployedMods * refactor rename uninstallExtensionsAndSaveState -> deactivateModComponentsAndSaveState * refactor rename vars in deactivateModComponentsAndSaveState * reactor rename uninstallExtensinoFromStates -> deactivateModComponentFromStates * refactor rename setExtensionsState -> saveModComponentStateAndReactivateTabs * refactor rename uninstallUmnatchedDeployments -> deactivateUnassignedDeployments * refactor rename uninstallRecipe -> deactivateMod * refactor rename installDeployment -> activateDeployment * refactor rename installDeployments -> activateDeployments * refacto rename canAutomaticallyInstall -> canAutoActivate * refactor rename vars in activateDeploymentsInBackground * refactor clarify manual/auto activation logic in activateDeploymentsInBackground * refactor consolidate resetUpdateTimestamp func * replace straggling references to 'install' with 'activate' * add test for changing mod id * fix test inteference in deploymentUpdater * add empty test file for activateDeployments * fix name and docs for updatePromptTimestamp * refactor integrate graham suggestion * add empty test to DeploymentsContext * add basic test body * update deployment timestamps * fix type errors * fix registry id in test * finish replication test * refactor rename activateDeployment param installed -> activatedModComponents * refactor rename activateDeployments param installed -> activatedModComponents * refactor consolidate redundant prop * refactor rename extension -> modComponent * bugfix deactivate mods based on deloyment id instead of recipe id * Refactor improve deploymentOverride spread * refactor extract mockDeploymentActivationRequests * add test for unmanaged activated mod becoming managed * fix type errors * fix modcomponentstate tyep errors * misc refactors * fix lint errors * add restricted flags mock * make fix for deactivate unmananged mod components * remove deactivate unassigned * remove todos in tests * add unassignedModComponents to deploymentUpdateState * refactor rename activeExtensions -> activeModComponents * refactor rename installedExtensions -> activatedModComponents * add unassignedModComponents to useAutoDeploy * deactivate unassigned mod components in useAutoDeploy effect * fix autoDeploy tests * remove unnecessary async * fix lint errors' * add try catch to deactivateUnassignedModComponents * fix lint errors * create useDeactivateUnassignedDeploymentsEffect * replace useAutoDeploy deactivateUnassignedModComponents with effect * replace useAutoDeploy deactivateUnassignedModComponents with effect * remove from strictnull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
To Reproduce
Steps to reproduce the behavior:
Actual behavior
Expected behavior
Desktop (please complete the following information):
Workaround
Discussion
Related Issues
Related Code
pixiebrix-extension/src/background/deploymentUpdater.ts
Line 171 in 73072cc
Implementation Sketch
pixiebrix-extension/src/extensionConsole/pages/deployments/DeploymentsContext.tsx
Line 116 in 73072cc
useRemoveDeploymentsEffect
hook and pass the unavailable deployments. NOTE: be careful to only remove the unavailable deployments if the deployments request succeeded (i.e., the set of deployments is known)The text was updated successfully, but these errors were encountered: