Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unavailable deployments not uninstalled on Extension Console refresh #8131

Closed
twschiller opened this issue Apr 1, 2024 · 1 comment · Fixed by #8164
Closed

Unavailable deployments not uninstalled on Extension Console refresh #8131

twschiller opened this issue Apr 1, 2024 · 1 comment · Fixed by #8164
Assignees
Labels
bug Something isn't working

Comments

@twschiller
Copy link
Contributor

twschiller commented Apr 1, 2024

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. Create a deployment with a group
  2. Refresh the Extension Console
  3. Pause the deployment and immediately remove the group from the deployent (marking as paused is likely not required to replicate, but is what the customer did)
  4. Refresh the Extension Console

Actual behavior

  1. The deployment is still installed

Expected behavior

  1. The deployment is automatically uninstalled after the assigned deployments are fetched

Desktop (please complete the following information):

  • Extension Version: 1.8.11

Workaround

  • Close the extension console and wait 5 minutes for the next heart beat, or
  • Toggle off/on the browser extension to force a background heartbeat

Discussion

Related Issues

Related Code

Implementation Sketch

@twschiller twschiller added the bug Something isn't working label Apr 1, 2024
@twschiller twschiller modified the milestone: 1.8.12 Apr 1, 2024
@twschiller twschiller changed the title Unavailable deployments not uninstalled when on Extension Console refresh Unavailable deployments not uninstalled on Extension Console refresh Apr 2, 2024
@twschiller
Copy link
Contributor Author

twschiller commented Apr 3, 2024

@grahamlangford based on @mnholtz investigation these 2 issues likely have the same root cause and should likely be worked on together: #7475

@fungairino fungairino assigned fungairino and unassigned fungairino Apr 3, 2024
@mnholtz mnholtz self-assigned this Apr 3, 2024
mnholtz added a commit that referenced this issue Apr 5, 2024
* refactor rename extensions -> activatedModComponents

* refactor rename uninstallAllDeployments -> deactivateAllDeployedMods

* refactor rename vars in deactivateAllDeployedMods

* refactor rename uninstallExtensionsAndSaveState -> deactivateModComponentsAndSaveState

* refactor rename vars in deactivateModComponentsAndSaveState

* reactor rename uninstallExtensinoFromStates -> deactivateModComponentFromStates

* refactor rename setExtensionsState -> saveModComponentStateAndReactivateTabs

* refactor rename uninstallUmnatchedDeployments -> deactivateUnassignedDeployments

* refactor rename uninstallRecipe -> deactivateMod

* refactor rename installDeployment -> activateDeployment

* refactor rename installDeployments -> activateDeployments

* refacto rename canAutomaticallyInstall -> canAutoActivate

* refactor rename vars in activateDeploymentsInBackground

* refactor clarify manual/auto activation logic in activateDeploymentsInBackground

* refactor consolidate resetUpdateTimestamp func

* replace straggling references to 'install' with 'activate'

* add test for changing mod id

* fix test inteference in deploymentUpdater

* add empty test file for activateDeployments

* fix name and docs for updatePromptTimestamp

* refactor integrate graham suggestion

* add empty test to DeploymentsContext

* add basic test body

* update deployment timestamps

* fix type errors

* fix registry id in test

* finish replication test

* refactor rename activateDeployment param installed -> activatedModComponents

* refactor rename activateDeployments param installed -> activatedModComponents

* refactor consolidate redundant prop

* refactor rename extension -> modComponent

* bugfix deactivate mods based on deloyment id instead of recipe id

* Refactor improve deploymentOverride spread

* refactor extract mockDeploymentActivationRequests

* add test for unmanaged activated mod becoming managed

* fix type errors

* fix modcomponentstate tyep errors

* misc refactors

* fix lint errors

* add restricted flags mock

* make fix for deactivate unmananged mod components

* remove deactivate unassigned

* remove todos in tests

* add unassignedModComponents to deploymentUpdateState

* refactor rename activeExtensions -> activeModComponents

* refactor rename installedExtensions -> activatedModComponents

* add unassignedModComponents to useAutoDeploy

* deactivate unassigned mod components in useAutoDeploy effect

* fix autoDeploy tests

* remove unnecessary async

* fix lint errors'

* add try catch to deactivateUnassignedModComponents

* fix lint errors

* create useDeactivateUnassignedDeploymentsEffect

* replace useAutoDeploy deactivateUnassignedModComponents with effect

* replace useAutoDeploy deactivateUnassignedModComponents with effect

* remove from strictnull
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants