#8131 Auto-deactivate unassigned mods on Mods Page

[mnholtz]

What does this PR do?

• Closes Unavailable deployments not uninstalled on Extension Console refresh #8131
• Some light rename refactoring where appropriate

Discussion

• Tentatively put the deactivation logic inside the useAutoDeploy useEffect instead of creating a separate effect to put somewhere. Happy to extract that out into its own effect, though; it's something that I considered.

Demo

• https://www.loom.com/share/3bd4caf5cb5d4649ac3183cdc6c6b6db

Todo

• Write unit tests

Checklist

• Add tests and/or storybook stories
• Designate a primary reviewer @grahamlangford

[mnholtz]

Also mirrors logic in deploymentUpdater, see deactivateUnassignedDeployments. It's tricky to extract and share this logic with the current architecture because the deploymentUpdater can't dispatch redux actions.

[grahamlangford]

deploymentUpdater can't dispatch redux actions.

Technically you can, you just have to manually call the reducer and use our set the resulting state using setReduxStorage

[mnholtz]

Technically you can, you just have to manually call the reducer and use our set the resulting state using setReduxStorage

Right, what I mean is that having to do that makes logic sharing tricky between the background and the react code

[grahamlangford]

Tentatively put the deactivation logic inside the useAutoDeploy useEffect instead of creating a separate effect to put somewhere. Happy to extract that out into its own effect, though; it's something that I considered.

useAutoDeploy is only supposed to trigger for restricted users. Perhaps we should rename it useAutoDeployForRestrictedUsers or similar.

I think we're violating SRP here. I would extract it to it's own custom hook.

[mnholtz]

This is the fix

[mnholtz]

I tried to add to strict null but had to remove due to dependency issues