Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default options in locator.refresh #840

Closed
twschiller opened this issue Jul 18, 2021 · 0 comments · Fixed by #841
Closed

Fix default options in locator.refresh #840

twschiller opened this issue Jul 18, 2021 · 0 comments · Fixed by #841
Assignees
Labels
bug Something isn't working

Comments

@twschiller
Copy link
Contributor

twschiller commented Jul 18, 2021

The options argument for refresh is marked as optional, but calling refresh without any arguments was causing an NPE, which was breaking:

  • The automatic deployment logic
  • Updates to the available services after configuring a service
@twschiller twschiller added the bug Something isn't working label Jul 18, 2021
@twschiller twschiller self-assigned this Jul 18, 2021
twschiller added a commit that referenced this issue Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant