#3347: include trigger event data

[twschiller]

What does this PR do?

• Closes Pass native keyboard event data with trigger #3347
• Passes keyboard event data in an "event" property in the input
• Adds support for "keypress" event

Out of Scope

• Include an official reader with an output schema for event like we do for context menus. There's not much advantage since the shape changes per event
• Show in the the preview of the data panel. (Also would require creating a fake reader)

[codecov-commenter]

Codecov Report

Merging #3348 (3dd1b39) into main (74b411e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
- Coverage   36.86%   36.85%   -0.02%     
==========================================
  Files         751      751              
  Lines       21520    21527       +7     
  Branches     4600     4602       +2     
==========================================
  Hits         7934     7934              
- Misses      12669    12675       +6     
- Partials      917      918       +1     

Impacted Files	Coverage Δ
src/extensionPoints/triggerExtension.ts	8.94% <0.00%> (-0.27%)	⬇️
...c/pageEditor/tabs/trigger/TriggerConfiguration.tsx	32.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b411e...3dd1b39. Read the comment docs.

[fregante]

If you turn this into a non-spread array you can have it as the first parameter. This way you don't have to pass around NO_NATIVE_EVENT since it's the second parameter and can be empty. It's slightly less convenient but IMHO better than an optional first parameter.

- await this.debouncedRunTriggersAndNotify(NO_NATIVE_EVENT, ...$root);
+ await this.debouncedRunTriggersAndNotify($root.get()); // jQuery -> Array

- void this.debouncedRunTriggersAndNotify(NO_NATIVE_EVENT, element);
+ void this.debouncedRunTriggersAndNotify([element]); // Single element -> Array

[twschiller]

A swapped the order and made an object for nullable params. I kept the param as non-optional because I want to make the behavior very explicit for readability

[fregante]

This could be typed:

Suggested change

	function pickEventProperties(nativeEvent: Event): UnknownObject {
	function pickEventProperties(nativeEvent: Event): SerializableKeyboardEvent | null {

interface SerializableKeyboardEvent {
	key: number;
	keyCode: number;
	metaKey: boolean;
	altKey: boolean;
	shiftKey: boolean;
	ctrlKey: boolean;
}

[twschiller]

This could be typed

I don't think there's much value in typing it yet because the caller doesn't care what it gets back as long as it's serializable. The return type should be JsonObject. But picks type signature isn't precise enough to support that