-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various import/copy cleanup, avoid unnecessary library injection #3511
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3511 +/- ##
==========================================
+ Coverage 40.34% 40.35% +0.01%
==========================================
Files 769 769
Lines 22407 22401 -6
Branches 4711 4709 -2
==========================================
Hits 9040 9040
+ Misses 12449 12443 -6
Partials 918 918
Continue to review full report at Codecov.
|
// As of Ember 4.6.0 this is not a real Symbol, so Object.keys should detect it. If they change it, this will stop working: | ||
// https://github.com/emberjs/ember.js/blob/55ffe6326f11efcaeb278cdf7e0f86543daa9f04/packages/%40ember/-internals/utils/lib/symbol.ts#L14-L26 | ||
// https://github.com/emberjs/ember.js/blob/55ffe6326f11efcaeb278cdf7e0f86543daa9f04/packages/%40ember/-internals/views/lib/compat/attrs.ts#L1 | ||
return Object.keys(cell).some((key) => key.startsWith("__MUTABLE_CELL")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to the updated links, specifically this line:
A few small changes:
browser.*
APIs whenever possible (a previous bug has been fixed)testMatchPatterns
by converting one pattern at a time + add tests<p>
in<p>
) that appears in the Options pageBefore
After
Fixed via: