#3673: add retry and random bricks #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3674 +/- ##
==========================================
+ Coverage 45.62% 45.68% +0.06%
==========================================
Files 816 818 +2
Lines 24412 24460 +48
Branches 5143 5150 +7
==========================================
+ Hits 11138 11175 +37
- Misses 12357 12368 +11
Partials 917 917
Continue to review full report at Codecov.
|
BLoe
approved these changes
Jun 13, 2022
Comment on lines
49
to
52
| floating: { | ||
| type: "boolean", | ||
| description: "Specify returning a floating-point number.", | ||
| }, |
There was a problem hiding this comment.
This could maybe be a little more clear to specify integer or float in the description.
Comment on lines
39
to
48
| lower: { | ||
| type: "number", | ||
| description: "The lower bound", | ||
| default: 0, | ||
| }, | ||
| upper: { | ||
| type: "number", | ||
| description: "The upper bound", | ||
| default: 1, | ||
| }, |
There was a problem hiding this comment.
We might want to specify inclusive/exclusive in the descriptions here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discussion
Future Work
Checklist