Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3669: fix pending brick status in extension overview #3670

Merged
merged 3 commits into from Jun 13, 2022

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Jun 12, 2022

What does this PR do?

Remaining work

  • Make the in progress icon match the other SVG icons. @BALEHOK where/how did you make those icons? Using a play icon sort of makes it look like a button. Using a spinner or lightening bolt might be better. Using a light blue/purple (to stand out against the active color) probably makes sense

Checklist

  • 😞 Add tests
  • Designate a primary reviewer: @BALEHOK

@twschiller twschiller requested review from BLoe and BALEHOK June 12, 2022 22:09
@twschiller twschiller changed the title #3669: fix pending brick status #3669: fix pending brick status in extension overview Jun 12, 2022
@twschiller twschiller added this to the 1.7.0 milestone Jun 12, 2022
@twschiller twschiller assigned twschiller and BALEHOK and unassigned twschiller Jun 12, 2022
@@ -281,23 +320,15 @@ const EditorNodeLayout: React.FC<EditorNodeLayoutProps> = ({
};

if (block) {
const runStatus: RunStatus =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted to separate function

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2022

Codecov Report

Merging #3670 (ba04eb7) into main (bd04892) will decrease coverage by 0.00%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main    #3670      +/-   ##
==========================================
- Coverage   45.74%   45.73%   -0.01%     
==========================================
  Files         819      819              
  Lines       24488    24493       +5     
  Branches     5158     5154       -4     
==========================================
  Hits        11201    11201              
- Misses      12370    12374       +4     
- Partials      917      918       +1     
Impacted Files Coverage Δ
src/pageEditor/tabs/editTab/editTabTypes.ts 100.00% <ø> (ø)
...editTab/editorNodes/brickNode/BrickNodeContent.tsx 58.97% <0.00%> (-4.92%) ⬇️
src/runtime/reducePipeline.ts 80.40% <ø> (ø)
src/telemetry/trace.ts 46.55% <ø> (ø)
...tabs/editTab/editorNodeLayout/EditorNodeLayout.tsx 63.58% <42.85%> (-0.75%) ⬇️
src/pageEditor/hooks/useExtensionTrace.ts 79.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd04892...ba04eb7. Read the comment docs.

@twschiller twschiller marked this pull request as draft June 13, 2022 01:37
@twschiller twschiller assigned twschiller and unassigned BALEHOK Jun 13, 2022
@twschiller twschiller marked this pull request as ready for review June 13, 2022 14:47
@twschiller twschiller merged commit 4fbfb7f into main Jun 13, 2022
@twschiller twschiller deleted the feature/3669-pending-brick-status branch June 13, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension overview showing success icon for in-progress brick
3 participants