-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3669: fix pending brick status in extension overview #3670
Conversation
@@ -281,23 +320,15 @@ const EditorNodeLayout: React.FC<EditorNodeLayoutProps> = ({ | |||
}; | |||
|
|||
if (block) { | |||
const runStatus: RunStatus = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted to separate function
Codecov Report
@@ Coverage Diff @@
## main #3670 +/- ##
==========================================
- Coverage 45.74% 45.73% -0.01%
==========================================
Files 819 819
Lines 24488 24493 +5
Branches 5158 5154 -4
==========================================
Hits 11201 11201
- Misses 12370 12374 +4
- Partials 917 918 +1
Continue to review full report at Codecov.
|
What does this PR do?
isFinal
flag on trace exits to avoid some gotchas with null/undefined effect outputsRemaining work
Checklist