#4489 Report tab slice errors properly

[BLoe]

What does this PR do?

• Fixes RTK errors are swallowed (no log, no report) #4489
• Sets the state error properly for editor slice thunks
• Fixes the top-level error alert in EditorContent

Demo

https://www.loom.com/share/2e5948b1265444c19f6affe01c05b0ce

Checklist

• Add tests
• Run Storybook and manually confirm that all stories are working
• Designate a primary reviewer - @BALEHOK

[codecov]

Codecov Report

Merging #4623 (f8fee64) into main (69bdc55) will increase coverage by 0.48%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main    #4623      +/-   ##
==========================================
+ Coverage   50.90%   51.39%   +0.48%     
==========================================
  Files         915      915              
  Lines       26985    27122     +137     
  Branches     5515     5515              
==========================================
+ Hits        13736    13938     +202     
+ Misses      12313    12250      -63     
+ Partials      936      934       -2     

Impacted Files	Coverage Δ
src/pageEditor/tabState/tabStateSlice.ts	33.33% <0.00%> (+33.33%)	⬆️
src/testUtils/testHelpers.tsx	96.07% <ø> (ø)
src/pageEditor/EditorContent.tsx	74.57% <100.00%> (+74.57%)	⬆️
src/pageEditor/slices/editorSlice.ts	55.73% <100.00%> (+1.34%)	⬆️
src/pageEditor/testHelpers.ts	100.00% <100.00%> (ø)
src/pageEditor/slices/editorSelectors.ts	84.92% <0.00%> (+1.58%)	⬆️
src/pageEditor/utils.ts	78.57% <0.00%> (+2.38%)	⬆️
src/components/Alert.tsx	75.00% <0.00%> (+15.00%)	⬆️
src/pageEditor/tabs/logs/useLogsBadgeState.ts	29.41% <0.00%> (+29.41%)	⬆️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

[fregante]

I'm not familiar with how slices work. How likely is it that two "nested slices" get the same error and report it twice?

[BLoe]

I'm not familiar with how slices work. How likely is it that two "nested slices" get the same error and report it twice?

Redux slices created with redux toolkit aren't nested within each other, is that what you're talking about?

[fregante]

Basically we had issues in the past with "reportError and re-throw", which meant that the error was caught again downstream and reported again. Can that happen here?

I see that each slice has to "return an error" (state.error = error) while also reporting it, meaning that the error will be available outside the slice. If the returned error is used exclusively for display, then it won't happen and this fine.

[fregante]

This should be dropped, context invalidation errors are not reported.