Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Color Replace Filter Deprecations #419

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Chore: Color Replace Filter Deprecations #419

merged 4 commits into from
Feb 14, 2024

Conversation

bbazukun123
Copy link
Collaborator

  • Add deprecations for the Color Replace filter.
  • Use GpuProgram.from and GlProgram.from for caching.

bigtimebuddy
bigtimebuddy requested changes Feb 14, 2024
View reviewed changes
src/color-replace/ColorReplaceFilter.ts Outdated Show resolved Hide resolved
src/color-replace/ColorReplaceFilter.ts Outdated Show resolved Hide resolved
bigtimebuddy
bigtimebuddy approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work on all these filters! You've really been a champion with all the feedback. I know it's kinda tedious, but these changes make the library more stable.

@bbazukun123
Copy link
Collaborator Author

bbazukun123 commented Feb 14, 2024 •
edited
Loading

Thanks for all your work on all these filters! You've really been a champion with all the feedback. I know it's kinda tedious, but these changes make the library more stable.

No, thank YOU Matt! I'm quite new to this stuff so definitely needed these :)

@bigtimebuddy bigtimebuddy merged commit 4cdc7a8 into main Feb 14, 2024
2 checks passed
@bigtimebuddy bigtimebuddy deleted the chore-deprecation-color-replace branch February 14, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@GoodBoyDigital GoodBoyDigital Awaiting requested review from GoodBoyDigital

@Zyie Zyie Awaiting requested review from Zyie

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbazukun123 @bigtimebuddy