Skip to content

Commit

Permalink
fix: spritesheet resolver not working (#10568)
Browse files Browse the repository at this point in the history
* fix: spritesheet resolver not working

* add test
  • Loading branch information
Zyie committed May 23, 2024
1 parent 285f45d commit fb04b66
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/assets/resolver/parsers/resolveJsonUrl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ import type { ResolveURLParser } from '../types';
* @memberof assets
*/
export const resolveJsonUrl = {
extension: ExtensionType.ResolveParser,
extension: {
type: ExtensionType.ResolveParser,
priority: -2,
},
test: (value: string): boolean =>
Resolver.RETINA_PREFIX.test(value) && value.endsWith('.json'),
parse: resolveTextureUrl.parse,
Expand Down
21 changes: 21 additions & 0 deletions tests/assets/Resolver.tests.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { Assets } from '../../src/assets/Assets';
import { resolveJsonUrl } from '../../src/assets/resolver/parsers/resolveJsonUrl';
import { resolveTextureUrl } from '../../src/assets/resolver/parsers/resolveTextureUrl';
import { getUrlExtension, Resolver } from '../../src/assets/resolver/Resolver';
import { extensions, ExtensionType } from '../../src/extensions/Extensions';
import { spritesheetAsset } from '../../src/spritesheet/spritesheetAsset';
import { manifest } from './sampleManifest';

import type { FormatDetectionParser } from '../../src/assets/detections/types';
Expand Down Expand Up @@ -46,6 +48,25 @@ describe('Resolver', () =>
expect(resolvedAsset.src).toBe('src.best');
});

it('should parse using the spritesheet parser', async () =>
{
extensions.add(spritesheetAsset, resolveJsonUrl);

await Assets.init();

Assets.resolver.add({
alias: 'test',
src: [
'src@2x.webp.json',
'src@2x.png.json',
]
});

const resolvedAsset = Assets.resolver.resolve('test');

expect(resolvedAsset.src).toBe('src@2x.webp.json');
});

it('should resolve asset', () =>
{
const resolver = new Resolver();
Expand Down

0 comments on commit fb04b66

Please sign in to comment.