Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: circular deps #10280

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Fix: circular deps #10280

merged 4 commits into from
Mar 8, 2024

Conversation

GoodBoyDigital
Copy link
Member

fixes circular dependancies in the code

Copy link

codesandbox-ci bot commented Mar 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit adcafec:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title Chore/circular deps Chore: fix circular deps Mar 6, 2024
@Zyie Zyie changed the title Chore: fix circular deps Fix: circular deps Mar 6, 2024
@bigtimebuddy
Copy link
Member

I think we should add failAfterWarnings (docs) which should fail the build for future circular dependency warnings.

@Zyie Zyie added the v8 label Mar 6, 2024
@Zyie
Copy link
Member

Zyie commented Mar 6, 2024

I think we should add failAfterWarnings (docs) which should fail the build for future circular dependency warnings.

added!

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Mar 6, 2024
@Zyie Zyie added this pull request to the merge queue Mar 8, 2024
Merged via the queue into dev with commit 6ea1cfc Mar 8, 2024
4 checks passed
@Zyie Zyie deleted the chore/circular-deps branch March 8, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t v8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants